Skip to content

Conversation

RoddieKieley
Copy link
Contributor

Small update to include a reference on how to use a custom values file to install via helm chart. References the newly included values-openshift.yaml which has been bumped to include the latest released version of the operator 0.2.8.

Open question; for the custom values file, values-openshift.yaml in this case, how should it be referenced to be consistent with other README's and the docs?
./values-openshift.yaml (assuming it's in the current dir but being explicit)
values-openshift.yaml (also assuming it's in the current directory but implicit)
./deploy/charts/operator/values-openshift.yaml (assuming one has cloned the repo and is in the root of the project)
raw github ref?

Please feel free to update as required.

@ChrisJBurns
Copy link
Collaborator

@claude Can you please bump the operator chart by a fix version. Make sure to follow the bumping instructions in the claude.md in the Operator Chart directory.

Copy link
Contributor

claude bot commented Aug 19, 2025

Claude encountered an error —— View job

Failed with exit code 128

I'll analyze this and get back to you.

@ChrisJBurns
Copy link
Collaborator

Ahh I just realised Claude doesn't work on forked branches. @RoddieKieley You'll have to bump up the Charts manually I'm afraid :(

@RoddieKieley RoddieKieley force-pushed the custom-helm-chart-values-README-update branch from e89b543 to 95e3303 Compare August 19, 2025 18:15
JAORMX
JAORMX previously approved these changes Aug 19, 2025
@RoddieKieley RoddieKieley force-pushed the custom-helm-chart-values-README-update branch from 95e3303 to d44588c Compare August 19, 2025 18:31
@RoddieKieley RoddieKieley requested a review from JAORMX August 19, 2025 18:42
@RoddieKieley
Copy link
Contributor Author

RoddieKieley commented Aug 19, 2025

I think @jhrozek was correct that the changes to values-openshift.yaml made it into main elsewhere as when I rebased on main I was just left with the update to the README.md and the README.md.gotmpl file updates. Being a bit new to this workflow I also had still missed the separate bump from 0.2.5 to 0.2.6, which should also now be resolved as per the checks passing atm. @JAORMX apologies for making your thumbs up quickly stale and having to re-request the review.

@JAORMX JAORMX merged commit 8a61a31 into stacklok:main Aug 19, 2025
4 checks passed
@RoddieKieley RoddieKieley deleted the custom-helm-chart-values-README-update branch August 19, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants